Use realloc for histogram cache and expose the cache limit.
#9455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
approved these changes
Aug 10, 2023
|
BTW, I did some benchmark, the performance is unchanged. |
|
cc @WeichenXu123 for awareness. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following are plots with 4 local workers from
LocalCluster. The initial spike in the plot is not accurate. Please note that memory usage withLocalClusterdoes not represent real world usage. The histogram cache is built for each worker.The memory spike observed in #9452 is caused by
std::vector::resize. I'm not sure which one is actually better for a longer term.The memory usage can not be directly compared to 1.7.x as we have a new estimation method for intercept. To disable it, set the
base_scoreto0.5(default in 1.7).I have exposed the limit as a parameter to the user interface so that there's at least an option when things get dire.
Close #9452 .